Keep the pool from closing a connection assigned to a queued request - #1111
Open
moldhouse wants to merge 1 commit into
Open
Keep the pool from closing a connection assigned to a queued request#1111moldhouse wants to merge 1 commit into
moldhouse wants to merge 1 commit into
Conversation
Assigning a connection to a PoolRequest leaves the connection IDLE until the request starts on it, so a concurrent pass over the pool could close it as surplus or to make room, sometimes underneath a request that had already been sent. Closes encode#1110.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1110.
_assign_requests_to_connectionsnow treats a connection referenced by a pendingPoolRequestas not idle, both when cleaning up connections and when picking an idle connection to close for making room. Without this a connection handed to a queued request could be closed by a concurrent pass before, or worse after, the request started on it.The regression test drives the pool's assignment pass directly, since the race cannot be reproduced deterministically through the public API.
scripts/unasync.pygains ahttpcore._async->httpcore._syncsubstitution so the test can importAsyncPoolRequest.